Tests checking implementation of checkpointing/SolverState#173
Merged
BenjaminRodenberg merged 8 commits intoprecice:developfrom Aug 20, 2024
Merged
Tests checking implementation of checkpointing/SolverState#173BenjaminRodenberg merged 8 commits intoprecice:developfrom
BenjaminRodenberg merged 8 commits intoprecice:developfrom
Conversation
Contributor
|
To make sure: At the moment we expect this test to fail. As soon as #172 is merged this test should succeed. Correct? |
BenjaminRodenberg
suggested changes
Aug 5, 2024
Contributor
BenjaminRodenberg
left a comment
BenjaminRodenberg
left a comment
There was a problem hiding this comment.
Some minor readability concerns. As soon as you merged the current state of develop into this PR the tests should work again.
Contributor
Author
Yes |
Contributor
|
Ok. Then I will merge the tests soon. This leads to failure on |
BenjaminRodenberg
approved these changes
Aug 20, 2024
Contributor
BenjaminRodenberg
left a comment
BenjaminRodenberg
left a comment
There was a problem hiding this comment.
Looks good to me and also tests the right thing! Thanks for the contribution. Will merge this now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests are written in context of Pull Request #172
Since the core functionality of the checkpointing is implemented in the SolverState class, the tests are actually testing only this class.
This commit consists of three different tests:
vector(). After that, load the checkpoint.assign(). After that, load the checkpoint.